Opened 10 years ago

Closed 10 years ago

#736 closed cleanup (duplicate)

Fix FIXME in tpx

Reported by: don la dieu Owned by: Javier Gonzalez
Priority: normal Milestone:
Component: other Keywords: icetop tpx
Cc:

Description

tpx contains an old FIXME in a #warning. FIXME's need to be fixed, or turned into proper documentation as a code comment.

For context:

if (domStatus.domGainType == I3DOMStatus::High &&
     (!std::isfinite(vemCalibration.hglgCrossOver) || vemCalibration.hglgCrossOver<=0))
    {
 #warning FIXME: This is kind of fishy. Subsequent modules should not have to do this check again.
      // Only warn and use default value in case of problems. Not a critical error.
      log_warn("Invalid \"hglgCrossOver\" value (%.2f) for module %s. Using default value of 3000 pe!",
             vemCalibration.hglgCrossOver, omKey.str().c_str());
    }
 
  return true;
 }

Change History (1)

comment:1 Changed 10 years ago by Meike de With

  • Resolution set to duplicate
  • Status changed from new to closed

This is a duplicate of #409

Note: See TracTickets for help on using tickets.