Opened 8 years ago

Closed 7 years ago

Last modified 5 years ago

#1894 closed rumor / allegation (duplicate)

[millipede] New GCD file pushes reco energy just outside tolerance

Reported by: Alex Olivas Owned by: Alex Olivas
Priority: normal Milestone:
Component: combo reconstruction Keywords:
Cc: Kevin Meagher

Description

The test checks that the reco energy is within 5% of the seed energy. Switching from the really, really old GCD file to the most recent 2016 GCD file causes this difference to be 5.2%. Not a big deal, but worth looking into. For now I'm going to up that check to 6%, but this should be looked into further.

Change History (11)

comment:1 Changed 8 years ago by Jim Braun

I've updated the tests to allow 6% variation in energy, and I've also standardized the routine to get the full photon tables.

For moving to the trunk of test-data:

  1. We should use the 2012 GCD file in test-data/GCD for millipede_test_nugen and use the 2016 GCD file for monopod_test and pymillipede_test. The tests should pass with the 2016 GCD.
  1. We should consider moving the full photon tables we access from $I3_DATA into test-data or something similar. We just need to change the location in monopod_test.py:get_pxs()

The above will be handled by olivas.

comment:2 Changed 8 years ago by Jim Braun

  • Owner changed from jbraun to olivas
  • Status changed from new to assigned

comment:3 Changed 7 years ago by Alex Olivas

  • Owner changed from olivas to braun

comment:4 Changed 7 years ago by Alex Olivas

  • Owner changed from braun to olivas

Ooops.

comment:5 Changed 7 years ago by Alex Olivas

  • Milestone changed from November 2016 to March 2017

We should make sure all is well before the next release.

comment:6 Changed 7 years ago by Alex Olivas

  • Status changed from assigned to accepted

comment:7 Changed 7 years ago by Alex Olivas

  • Milestone changed from March 2017 to April 2017

comment:8 Changed 7 years ago by Alex Olivas

  • Milestone changed from April 2017 to June 2017

We'll plan the switch to test-data trunk for the summer solstice release series around late June, early July.

comment:9 Changed 7 years ago by Alex Olivas

  • Milestone changed from June 2017 to IceRec 5.2

comment:10 Changed 7 years ago by Alex Olivas

  • Resolution set to duplicate
  • Status changed from accepted to closed

Since the last thing to do is switch over to the trunk of test-data after that overhaul, this ticket is now a duplicate.

comment:11 Changed 5 years ago by Alex Olivas

  • Milestone IceRec 5.2 deleted

Milestone IceRec? 5.2 deleted

Note: See TracTickets for help on using tickets.